capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2699524213
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -229,6 +229,17 @@ protected boolean
isRootCausePacketTooBigException(Throwable t)
return false;
}
+ /**
+ * Checks if the root cause of the given exception is a unique constraint
violation.
+ *
+ * @return false by default. Specific implementations should override this
method
+ * to correctly classify their unique constraint violation exceptions.
+ */
+ public boolean isUniqueConstraintViolation(Throwable t)
+ {
+ return false;
+ }
Review Comment:
I lean towards dropping the default impl. tbh, idk why, when I was breaking
this out by database I didn't make this abstract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
