capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2699759945
##########
processing/src/main/java/org/apache/druid/guice/DruidSecondaryModule.java:
##########
@@ -164,6 +168,22 @@ public WireTransferableContext getWireTransferableContext(
return new WireTransferableContext(smileMapper, concreteDeserializer,
isUseLegacyFrameSerialization());
}
+ @Provides
+ @LazySingleton
+ @Deterministic
+ public ObjectMapper getSortedMapper(
+ Injector injector,
+ Map<ByteBuffer, WireTransferable.Deserializer> wtDeserializers
+ )
+ {
+ final ObjectMapper sortedMapper = new DefaultObjectMapper();
Review Comment:
Appreciate the discussion here. I think, from my reading of this and re-look
at the code, that the best path forward is going to be to bury the
deterministic mapper in the fingerprint mapper. That will be seeded from the
json mapper that the CompactionJobQueue already was having prior to this PR. I
think this gives us most logical current state and hopefully future flexibility
if things expand beyond the default mapper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
