FrankChen021 commented on code in PR #19917:
URL: https://github.com/apache/druid/pull/19917#discussion_r3736390376
##########
extensions-contrib/redis-cache/pom.xml:
##########
@@ -34,6 +34,21 @@
</parent>
<dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
Review Comment:
[P1] JUnit 4 tests inherited from CacheTestBase are no longer executed
RedisClusterCacheTest and RedisStandaloneCacheTest extend CacheTestBase,
whose testKeyContainingNegativeBytes method still uses org.junit.Test. This
module now declares only Jupiter and no Vintage engine, so those inherited
JUnit 4 tests are silently skipped. Migrate the shared test or retain Vintage
until it is converted.
##########
extensions-contrib/dropwizard-emitter/src/test/java/org/apache/druid/emitter/dropwizard/DropwizardEmitterConfigTest.java:
##########
@@ -26,19 +26,20 @@
import org.apache.druid.emitter.dropwizard.reporters.DropwizardJMXReporter;
import org.apache.druid.guice.JsonConfigTesterBase;
import org.apache.druid.jackson.DefaultObjectMapper;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
import java.io.IOException;
public class DropwizardEmitterConfigTest extends
JsonConfigTesterBase<DropwizardEmitterConfig>
{
private ObjectMapper mapper = new DefaultObjectMapper();
- @Before
- public void setUp()
+ @BeforeEach
+ public void setUp() throws IllegalAccessException
{
+ super.setup();
Review Comment:
[P1] Inherited JsonConfigTesterBase test is silently skipped
Calling super.setup() initializes the shared fixture, but
JsonConfigTesterBase.simpleInjectionTest is still annotated with
org.junit.Test. With this module migrated to Jupiter and JUnit 4 removed,
Jupiter will not discover that inherited test, dropping a config-injection
regression check. Convert the shared test or add an equivalent Jupiter test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
