FrankChen021 commented on code in PR #19917:
URL: https://github.com/apache/druid/pull/19917#discussion_r3736577889
##########
extensions-contrib/virtual-columns/src/test/java/org/apache/druid/segment/MapVirtualColumnGroupByTest.java:
##########
@@ -146,11 +146,11 @@ public void testWithMapColumn()
null
);
- Throwable t = Assert.assertThrows(
+ Throwable t = Assertions.assertThrows(
Review Comment:
No code change is needed here. In the PR base commit
[`fe4377a4`](https://github.com/apache/druid/blob/fe4377a48945449058ac62bc0971f2363431098b/extensions-contrib/virtual-columns/src/test/java/org/apache/druid/segment/MapVirtualColumnGroupByTest.java#L149-L153),
this test already declared `Throwable t = Assert.assertThrows(...)`. The
migration only changed the assertion API to Jupiter; the non-final assignment
predates this PR and is out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
