FrankChen021 commented on code in PR #19917:
URL: https://github.com/apache/druid/pull/19917#discussion_r3736780634
##########
extensions-contrib/redis-cache/pom.xml:
##########
@@ -34,6 +34,21 @@
</parent>
<dependencies>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-engine</artifactId>
Review Comment:
Fixed in commit `cdca32d972`. The Redis child tests now override
`testKeyContainingNegativeBytes()` with a Jupiter `@Test` and use
`Assertions.assertArrayEquals` directly, so the inherited coverage is
discovered without restoring JUnit 4 or Vintage. Focused Redis/Dropwizard
compilation and tests passed (RedisCluster: 3, RedisStandalone: 5), along with
Checkstyle and SpotBugs. Resolving this thread.
##########
extensions-contrib/dropwizard-emitter/src/test/java/org/apache/druid/emitter/dropwizard/DropwizardEmitterConfigTest.java:
##########
@@ -26,19 +26,20 @@
import org.apache.druid.emitter.dropwizard.reporters.DropwizardJMXReporter;
import org.apache.druid.guice.JsonConfigTesterBase;
import org.apache.druid.jackson.DefaultObjectMapper;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
import java.io.IOException;
public class DropwizardEmitterConfigTest extends
JsonConfigTesterBase<DropwizardEmitterConfig>
{
private ObjectMapper mapper = new DefaultObjectMapper();
- @Before
- public void setUp()
+ @BeforeEach
+ public void setUp() throws IllegalAccessException
{
+ super.setup();
Review Comment:
Fixed in commit `cdca32d972`. `DropwizardEmitterConfigTest` now has a
Jupiter `testSimpleInjection()` that preserves the inherited configuration
coverage with Jupiter assertions for all configurable fields, without restoring
JUnit 4 or Vintage. Focused Dropwizard tests passed (3), along with Checkstyle
and SpotBugs. Resolving this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
