FrankChen021 commented on code in PR #19921:
URL: https://github.com/apache/druid/pull/19921#discussion_r3758126952
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/duty/UnusedSegmentsKiller.java:
##########
@@ -474,7 +473,10 @@ private EmbeddedKillTask(
candidate.dataSource(),
candidate.interval(),
null,
- Map.of(Tasks.PRIORITY_KEY,
Tasks.DEFAULT_EMBEDDED_KILL_TASK_PRIORITY),
+ Map.of(
+ Tasks.PRIORITY_KEY, Tasks.DEFAULT_EMBEDDED_KILL_TASK_PRIORITY,
+ Tasks.TASK_LOCK_TYPE, TaskLockType.KILL.name()
Review Comment:
Confirmed fixed at this head: `getLockedIntervals` now ignores `KILL` locks
for non-`KILL` requests, with regression coverage. I reviewed all 37 changed
files and found no additional issues.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
