gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474081070 The method is marked `@VisibleForTesting`, which is like a way of saying "should be private, but has to be public so tests can use it". So probably the real bug is that DruidCoordinatorLogger is using it at all. It also brings up that it would be nice to have some automation around detecting when `@VisibleForTesting` are used in production code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org