gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474102354 I don't really love that solution. Adding "InTest" seems to me like it would be pretty ugly, especially in the 200+ places that we have a VisibleForTesting annotation today. And using a naming convention like this could make people mistakenly think the method is _only_ used for testing. Lots of the methods with this annotation today are meant to be used in production, but just privately. Maybe better to keep things the way they are, then.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
