gianm commented on issue #7285: Fix concurrency of VersionedIntervalTimeline URL: https://github.com/apache/incubator-druid/issues/7285#issuecomment-474095468 In that case, maybe I misunderstand what `@VisibleForTesting` is for. Personally I've always used it to mean "would be private, but needs to be package-private or public so it can be used in tests". If it doesn't mean that, it'd be nice to add an annotation that _does_ mean that, since I think it's useful. That way it could potentially be verified automatically.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
