capistrant commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3839396472
##########
server/src/main/java/org/apache/druid/server/coordinator/rules/RetentionRulesSnapshot.java:
##########
@@ -31,16 +31,26 @@
*/
public class RetentionRulesSnapshot
{
- private static final RetentionRulesSnapshot EMPTY = new
RetentionRulesSnapshot(Map.of(), List.of());
+ /**
+ * Conventional value of {@code druid.manager.rules.defaultRule}, used only
by
+ * {@link #withClusterDefaults}. Real snapshots take the configured name
from their caller,
+ * as an operator may have changed it.
+ */
+ private static final String DEFAULT_DATASOURCE_NAME = "_default";
Review Comment:
done and made sure to reference it only from tests. but I am a little
concerned about the way this default is floating around when an operator can
specify something different at runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
