FrankChen021 commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3843470536
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -736,6 +734,7 @@ public void run()
.builder()
.withDataSourcesSnapshot(dataSourcesSnapshot)
.withDynamicConfigs(metadataManager.configs().getCurrentDynamicConfig())
+
.withRetentionRulesSnapshot(metadataManager.rules().getRulesSnapshot())
Review Comment:
[P1] Rules and tier aliases can be mixed across snapshots
This new runtime snapshot reads the retention rules and the coordinator
dynamic config (including historicalTierAliases) independently. If either is
reloaded between these reads, a rule using an alias can be evaluated with the
previous alias map; StrategicSegmentAssigner then treats the unresolved alias
as a physical tier, can compute zero required replicas for real tiers, and
queue drops for existing replicas. Capture the rule/config pair consistently or
fail safely when an alias is unresolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
