capistrant commented on code in PR #20063:
URL: https://github.com/apache/druid/pull/20063#discussion_r3839360734
##########
server/src/main/java/org/apache/druid/metadata/MetadataRuleManagerConfig.java:
##########
@@ -26,8 +26,14 @@
*/
public class MetadataRuleManagerConfig
{
+ /**
+ * Default value of {@code druid.manager.rules.defaultRule}, i.e. the
datasource against which
+ * the cluster-level default rules are stored when an operator has not
configured another name.
+ */
+ public static final String DEFAULT_RULE_NAME = "_default";
Review Comment:
all usages in this PR are in test code. but leaving this around is a land
mine if some app code references it and then the operator changes it out from
under them.
##########
server/src/main/java/org/apache/druid/metadata/MetadataRuleManagerConfig.java:
##########
@@ -26,8 +26,14 @@
*/
public class MetadataRuleManagerConfig
{
+ /**
+ * Default value of {@code druid.manager.rules.defaultRule}, i.e. the
datasource against which
+ * the cluster-level default rules are stored when an operator has not
configured another name.
+ */
+ public static final String DEFAULT_RULE_NAME = "_default";
Review Comment:
all usages in this PR are in test code. but leaving this around is a land
mine if some app code references it and then the operator changes it out from
under them with a prop override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
