samarthjain commented on a change in pull request #7088: Improve parallelism of
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r266677981
##########
File path:
server/src/main/java/org/apache/druid/server/coordination/ZkCoordinator.java
##########
@@ -54,21 +56,25 @@
private volatile PathChildrenCache loadQueueCache;
private volatile boolean started = false;
+ private final ExecutorService segmentLoadUnloadService;
@Inject
public ZkCoordinator(
SegmentLoadDropHandler loadDropHandler,
ObjectMapper jsonMapper,
ZkPathsConfig zkPaths,
DruidServerMetadata me,
- CuratorFramework curator
+ CuratorFramework curator,
+ SegmentLoaderConfig config
)
{
this.dataSegmentChangeHandler = loadDropHandler;
this.jsonMapper = jsonMapper;
this.zkPaths = zkPaths;
this.me = me;
this.curator = curator;
+ this.segmentLoadUnloadService = Execs.multiThreaded(
+ config.getNumLoadingThreads(), "ZKCoordinator--%d");
Review comment:
I wish Intellij or Eclipse would just format this correctly. Working on
multiple projects, it gets difficult to remember coding styles of individual
projects. And doesn't seem like checkstyle complained about this either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
