samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277126496
########## File path: server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java ########## @@ -406,11 +409,11 @@ public void addCallback(LoadPeonCallback newCallback) } } - LoadPeonCallback[] getCallbacks() + List<LoadPeonCallback> snapshotCallbacks() { synchronized (callbacks) { // Return a copy so that callers get a consistent view Review comment: I think the comment I have makes more sense. While the possible inconsistency is because of the race condition, the comment delivers the fact that callers can expect a consistent view and need not worry about other threads concurrently modifying the returned collection. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org