samarthjain commented on a change in pull request #7088: Improve parallelism of
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277126584
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
##########
@@ -183,28 +172,17 @@ public void dropSegment(
final LoadPeonCallback callback
Review comment:
This class has been around forever and I agree that more could be done to
document the thread safety of the class. Having said that, I don't think this
PR should be focussing on it. It could possibly be addressed in
https://github.com/apache/incubator-druid/projects/4.
Looking at the callers of loadSegment() and dropSegment() I can't say for
sure if they could be called by multiple threads. It doesn't seem like it from
what I see. However, to better guard against future changes, I am going to
slightly change the code to use putIfAbsent instead of doing the racy
check-then-act.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
