FrankChen021 commented on code in PR #20199:
URL: https://github.com/apache/druid/pull/20199#discussion_r3904062299
##########
server/src/main/java/org/apache/druid/server/coordinator/stats/Stats.java:
##########
@@ -106,12 +106,25 @@ public static class SegmentQueue
public static class Tier
{
+ // Assignment budget of a tier, denominated in full segment size.
REQUIRED_CAPACITY is the demand the rules
+ // place on the tier to full load all segments, ASSIGNABLE_CAPACITY the
supply the tier advertises for it. Both are
+ // planning figures and may exceed the physical disk measured by
STORAGE_CAPACITY and USED_STORAGE when virtual
+ // storage is in use.
public static final CoordinatorStat REQUIRED_CAPACITY
= CoordinatorStat.toDebugAndEmit("reqdCap", "tier/required/capacity");
+ public static final CoordinatorStat ASSIGNABLE_CAPACITY
+ = CoordinatorStat.toDebugAndEmit("assignableCap",
"tier/assignable/capacity");
Review Comment:
[P2] Register new tier metrics in default emitter maps
The new `tier/assignable/capacity` and `tier/storage/used` stats are absent
from the bundled Prometheus, StatsD, and filtered logging metric maps, so
default exporters omit these metrics even though the coordinator emits them.
Add both metrics with their `tier` and `tierAlias` dimensions and gauge
semantics, plus mapping coverage tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
