FrankChen021 commented on code in PR #20199:
URL: https://github.com/apache/druid/pull/20199#discussion_r3914081756
##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -190,6 +190,9 @@
"tier/replication/factor" : { "dimensions" : ["tier", "tierAlias"], "type" :
"count", "help": "Configured maximum replication factor in each tier."},
"tier/required/capacity" : { "dimensions" : ["tier", "tierAlias"], "type" :
"count", "help": "Total capacity in bytes required in each tier."},
"tier/total/capacity" : { "dimensions" : ["tier", "tierAlias"], "type" :
"count", "help": "Total capacity in bytes available in each tier."},
+ "tier/assignable/capacity": { "dimensions" : ["tier", "tierAlias"], "type" :
"count", "help": "Total capacity in bytes available for assignment in each
tier."},
Review Comment:
[P1] Register tier state metrics as gauges
The new tier/assignable/capacity, tier/storage/capacity, and
tier/storage/used metrics are configured as Prometheus counters.
PrometheusEmitter increments counters for every coordinator event, so these
current-state values accumulate across cycles, never decrease when capacity or
usage falls, and are exposed with counter semantics. Configure all three as
gauge metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
