havefunatcode commented on PR #20782: URL: https://github.com/apache/druid/pull/20782#issuecomment-6570051967
Got it, thanks for explaining. Done in the latest commit. `OperandType` has `nullable()` now and the six aggregators use it, so `NULL` is accepted again. I added `NULL` and `CAST(NULL AS DOUBLE)` tests for each of them, and updated the description. Something I ran into while writing the TDigest tests: `TDIGEST_QUANTILE(m1, 0.5)` and `TDIGEST_GENERATE_SKETCH(m1)` in the same query fail with `Duplicate field name: a0:agg`. It happens with a regular column too, so it's not about NULL. I split the tests for now. I can open a separate issue for it if that's useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
