FrankChen021 commented on code in PR #20782:
URL: https://github.com/apache/druid/pull/20782#discussion_r4442523622
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchSqlAggregatorTest.java:
##########
@@ -1143,6 +1143,109 @@ public void testApproxQuantileWithStringResolution()
}
}
+ @Test
+ public void testApproxQuantileWithNonNumericStringLiteral()
Review Comment:
Rechecked the current head and all 22 changed files: numeric string literal
coverage is present for the doubles-sketch aggregators. No remaining issue from
this thread.
<!-- mergelens:review -->
##########
extensions-core/histogram/src/test/java/org/apache/druid/query/aggregation/histogram/sql/FixedBucketsHistogramQuantileSqlAggregatorTest.java:
##########
@@ -686,4 +686,40 @@ public void testGroupByAggregatorDefaultValues()
)
);
}
+
+ @Test
+ public void testQuantileWithNonNumericStringLiteral()
Review Comment:
Rechecked the current head and all 22 changed files: the fixed-buckets tests
cover the requested string-column, numeric-string-literal, and __time cases. No
remaining issue from this thread.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
