FrankChen021 commented on code in PR #20782:
URL: https://github.com/apache/druid/pull/20782#discussion_r4439442730
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java:
##########
@@ -594,6 +605,13 @@ protected SqlOperandTypeInference
buildOperandTypeInference()
final IntSet nullableOperands = requiredOperandCount == null
? new IntArraySet()
:
DefaultOperandTypeChecker.buildNullableOperands(requiredOperandCount,
operandTypes.size(), new IntArraySet());
+ if (operandTypes != null) {
Review Comment:
operandTypes can't be null here, right? and this new if block should be
moved into `buildNullableOperands`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
