leventov commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r282156967
##########
File path:
core/src/main/java/org/apache/druid/timeline/DataSegmentWithOvershadowedStatus.java
##########
@@ -25,16 +25,16 @@
/**
* DataSegment object plus the overshadowed status for the segment. An
immutable object.
*
- * SegmentWithOvershadowedStatus's {@link #compareTo} method considers only
the {@link SegmentId}
+ * DataSegmentWithOvershadowedStatus's {@link #compareTo} method considers
only the {@link SegmentId}
* of the DataSegment object.
*/
-public class SegmentWithOvershadowedStatus implements
Comparable<SegmentWithOvershadowedStatus>
+public class DataSegmentWithOvershadowedStatus implements
Comparable<DataSegmentWithOvershadowedStatus>
Review comment:
I don't think this is a good rename. I think ["DataSegment" is an
unfortunate name](https://github.com/apache/incubator-druid/issues/7396), so
why propagating it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
