leventov commented on a change in pull request #7595: Optimize overshadowed
segments computation
URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r288672814
##########
File path:
core/src/main/java/org/apache/druid/timeline/SegmentWithOvershadowedStatus.java
##########
@@ -31,6 +32,12 @@
public class SegmentWithOvershadowedStatus implements
Comparable<SegmentWithOvershadowedStatus>
{
private final boolean overshadowed;
+ /**
+ * dataSegment is serialized "unwrapped", i.e. it's properties are included
as properties of
+ * enclosing class. If in future, if {@Code SegmentWithOvershadowedStatus}
were to extend {@link DataSegment},
+ * there will be no change in the serialized format.
+ */
+ @JsonUnwrapped
Review comment:
Can you please also ensure that the data is sent in smile format, not JSON,
between Coordinator and Brokers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
