leventov commented on a change in pull request #7595: Optimize overshadowed segments computation URL: https://github.com/apache/incubator-druid/pull/7595#discussion_r290395194
########## File path: server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java ########## @@ -506,20 +477,7 @@ public boolean removeSegment(String dataSourceName, final String segmentId) public boolean removeSegment(SegmentId segmentId) Review comment: This method now looks the same as `public boolean removeSegment(String dataSourceName, final String segmentId)`, i. e. you can simplify (at least `dataSourceName` param is completely unused), potentially remove one of these methods completely. Also please update their Javadocs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
