leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342947361
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManager.java
##########
@@ -251,7 +251,9 @@ public void onFailure(Throwable t)
{
submitNoticeToExec(new StatusNotice(task,
TaskStatus.failure(task.getId())));
}
- }
+ },
+ // The callback is non-blocking and quick, so it's OK to schedule it
using directExecutor()
Review comment:
Please add a javadoc comment to `submitNoticeToExec()` like "This method is
mostly non-blocking because exec is a ThreadPoolExecutor with unbounded queue
used by default."
Correspondingly, this comment also should say "mostly non-blocking", not
just "non-blocking".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
