leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342951053
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java
##########
@@ -250,7 +254,8 @@ public void onFailure(Throwable t)
LOG.error(t, "Error while running a task for subTaskSpec[%s]",
spec);
taskCompleteEvents.offer(SubTaskCompleteEvent.fail(spec, t));
}
- }
+ },
+ blockingQueueHandler
Review comment:
Correction - `BlockingQueue.offer()` still needs to enter a critical
section, but it may be considered "mostly non-blocking", so directExecutor()
should still be OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
