leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342940087
##########
File path:
core/src/main/java/org/apache/druid/java/util/common/concurrent/ListenableFutures.java
##########
@@ -61,15 +61,19 @@ public void onFailure(Throwable t)
{
finalFuture.setException(t);
}
- });
+ },
+ // The callback is non-blocking and quick, so it's OK to schedule
it using directExecutor()
Review comment:
Too much indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
