ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357413942
########## File path: examples/bin/run-druid ########## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -if [ "$#" -gt 2 ] +if [ "$#" -gt 2 ] || [ "$#" == 0 ] Review comment: I think the `==` should be `-eq` since this is a numeric compare and not a string compare ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
