ccaominh commented on a change in pull request #9021: Allow startup scripts to
specify java home
URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357403722
##########
File path: examples/bin/verify-java
##########
@@ -44,7 +45,18 @@ if ($skip_var && $skip_var ne "0" && $skip_var ne "false"
&& $skip_var ne "f") {
exit 0;
}
-my $java_version = qx[java -version 2>&1];
+my $cwd = dirname(__FILE__);
+my $java_bin = `source $cwd/java-util && get_java_bin 2>&1`;
+# Strip trailing whitespace. Executing get_java_bin appears to append a
+# new line character at the end
Review comment:
In `get_java_bin`, you can use the "-n" option so that `echo` doesn't append
a newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
