ccaominh commented on a change in pull request #9021: Allow startup scripts to
specify java home
URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357404965
##########
File path: examples/bin/jconsole.sh
##########
@@ -43,4 +43,11 @@ if [ ! -e ${LOG4J_GUI_PATH} ]; then
fi
wait
-jconsole -pluginpath ${LOG4J_API_PATH}:${LOG4J_CORE_PATH}:${LOG4J_GUI_PATH} $@
+WHEREAMI="$(dirname "$0")"
+WHEREAMI="$(cd "$WHEREAMI" && pwd)"
+JAVA_BIN=`source "$WHEREAMI"/java-util && get_java_bin`
+if [ -z "$JAVA_BIN" ]; then
+ echo "Could not find java - please run $WHEREAMI/verify-java to confirm it
is installed."
Review comment:
Maybe we should change the script to print errors on `stderr` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
