himanshug edited a comment on pull request #10551:
URL: https://github.com/apache/druid/pull/10551#issuecomment-736143481
@zhangyue19921010 I think making Druid flexible to work with older versions
of Kafka is good, so +1 on that.
regarding the specific implementation here --
does the problem happen if `isolation.level=read_uncommitted` ? if no, then
all that is needed is to make "isolation.level" overridable via the `ioConfig`
instead of introducing another configuration `consumeTransactionally`.
That can be achieved by removing `props.put("isolation.level",
"read_committed");` from `KafkaConsumerConfigs.getConsumerProperties()` and
making that a default in `KafkaIndexTaskIOConfig` if `isolation.level` is not
explicitly supplied by the user.
does that make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
