zhangyue19921010 commented on pull request #10551:
URL: https://github.com/apache/druid/pull/10551#issuecomment-736260071
@himanshug Thanks for your review.
> does the problem happen if `isolation.level=read_uncommitted` ?
No problem will happen . When set `isolation.level` `read_uncommitted`,
Druid can consume higher version Kafka un-transactionally and Druid also can
consume lower version Kafka.
I just change the strategy for setting `isolation.level` in
`KafkaConsumerConfigs.getConsumerProperties()`.
`props.put("isolation.level",
customerConsumerProperties.getOrDefault("isolation.level", "read_committed"));`
If users ignore this parameter, Druid will set `isolation.level`
`read_committed` by default.
If users set `isolation.level` `read_committed` or set `isolation.level`
`read_uncommitted` in `ConsumerProperties`, Druid will set this parameter as
required by the user. In other words, user-property has a higher priority.
**This solution makes code changes lighter and safer. And this solution also
don't change current behavior of Kafka consumption and provide a way to make
Druid has the ability to consume lower versions of Kafka.**
PTAL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
