jon-wei opened a new pull request, #14463: URL: https://github.com/apache/druid/pull/14463
This PR fixes an issue with the `VARIANCE` and related SQL aggregation functions, allowing them to accept variance aggregator objects as inputs (currently the SQL function only accepts numeric operands). The new `SqlAggFunction` definitions are copied from `SqlStdOperatorTable` but the the operand type broadened to `ANY`. Note: once https://github.com/apache/druid/pull/14195 is merged, these new agg function definitions can be adjusted to use the `RowSignatures.complexTypeChecker` for tighter operand type checking. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
