clintropolis commented on code in PR #14463:
URL: https://github.com/apache/druid/pull/14463#discussion_r1239397609
##########
extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/sql/BaseVarianceSqlAggregator.java:
##########
@@ -137,21 +149,77 @@ public Aggregation toDruidAggregation(
);
}
+ private static class VarPopSqlAggFunction extends SqlAggFunction
+ {
+ VarPopSqlAggFunction()
+ {
+ super(
+ SqlKind.VAR_POP.name(),
+ null,
+ SqlKind.VAR_POP,
+ ReturnTypes.AVG_AGG_FUNCTION,
+ null,
+ OperandTypes.ANY, // Can be more specific after
https://github.com/apache/druid/pull/14195 is merged
Review Comment:
oh i should have read the PR description, you covered this 😛
I still think it would be nicer to pull in those changes since this PR seems
to be easier to merge and i think lots of other things could take advantage of
this helper method existing, but I guess this isn't a blocker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
