clintropolis commented on code in PR #14463: URL: https://github.com/apache/druid/pull/14463#discussion_r1239560886
########## extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/sql/BaseVarianceSqlAggregator.java: ########## Review Comment: yeah, I guess i was thinking with that pattern can just have a function that makes `SqlAggFunction` based on the parts that change instead of a bunch of separate classes. The other PR is removing many of the custom `SqlAggFunction` to replace with the builder so making a more complicated setup here with base class seems like it would conflict even more with the goals there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
