LakshSingla commented on code in PR #14196:
URL: https://github.com/apache/druid/pull/14196#discussion_r1246168209
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/common/SortMergeJoinFrameProcessor.java:
##########
@@ -353,7 +443,9 @@ private boolean allTrackersAreAtEnd()
}
/**
- * Compares the marked rows of the two {@link #trackers}.
+ * Compares the marked rows of the two {@link #trackers}. This method
returns 0 if both sides are null, even
Review Comment:
nit: We should also mention that we emit -1 if we should consider the LEFT
row and 1 if we should consider the RIGHT row. It might be a good refactor that
instead of `int` we use an ENUM to denote the three outcomes of `compareMarks`,
since the semantics differ slightly from an actual comparison algorithm
according to my understanding.
Eg, comparison (eg Java `compareTo`) returns something like (left - right),
while here we also consider ascending, and descending nature of the columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
