gianm commented on code in PR #14196:
URL: https://github.com/apache/druid/pull/14196#discussion_r1246823880
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/common/SortMergeJoinFrameProcessor.java:
##########
@@ -533,6 +629,11 @@ public long totalBytesBuffered()
return bytes;
}
+ public boolean canBufferMoreFrames()
Review Comment:
Sure thing. Added this:
```
/**
* Whether this tracker can accept more frames without exceeding {@link
#maxBufferedBytes}. Always returns true
* if the number of buffered frames is zero or one, because the join
algorithm may require two frames being
* buffered. (For example, if we need to verify that the last row in a
frame contains a complete set of a key.)
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
