gianm commented on code in PR #14196:
URL: https://github.com/apache/druid/pull/14196#discussion_r1246821539
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/common/SortMergeJoinFrameProcessor.java:
##########
@@ -353,7 +443,9 @@ private boolean allTrackersAreAtEnd()
}
/**
- * Compares the marked rows of the two {@link #trackers}.
+ * Compares the marked rows of the two {@link #trackers}. This method
returns 0 if both sides are null, even
Review Comment:
The `left - right` thing is an implementation detail of certain comparators.
It isn't required. In general, the contract of Java comparison is that negative
means the "first" thing is earlier, positive means the "second" thing is
earlier, and zero means they're equal. It's OK if comparators have a sense of
reversal (descending vs ascending) built into them or aren't implemented using
subtraction.
I think it's a good point that we should call out that "LEFT" is considered
the "first" thing. I updated the javadocs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
