kgyrtkirk opened a new pull request, #16741: URL: https://github.com/apache/druid/pull/16741
this patch changes the `WindowFrame` internals / representation a bit; introduces a dedicated frametype for `rows`, `groups`, `unbounded` - so that later if we decide to add better ranges support it will less likely need a bigger refactor it also changes how its represented in the native query: ```diff - frame: { peerType: "ROWS", lowUnbounded: true, lowOffset: 0, uppUnbounded: true, uppOffset: 0 } + frame: { type: unbounded } ``` ```diff - frame: { peerType: "ROWS", lowUnbounded: false, lowOffset: 0, uppUnbounded: false, uppOffset: 2 } + frame: { type: rows, lowerOffset: 0, upperOffset: 2 } ``` ```diff - frame: { peerType: "RANGE", lowUnbounded: true, lowOffset: 0, uppUnbounded: false, uppOffset: 0, orderBy: [{ column: l1, direction: ASC }] } + frame: { type: group, upperOffset: 0, orderBy: [{ column: l1, direction: ASC }] } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org