kgyrtkirk commented on code in PR #16741: URL: https://github.com/apache/druid/pull/16741#discussion_r1680856371
########## processing/src/test/java/org/apache/druid/query/rowsandcols/semantic/FramedOnHeapAggregatableTest.java: ########## @@ -371,7 +370,7 @@ public void testUnboundedWindowedAggregation() FramedOnHeapAggregatable agger = FramedOnHeapAggregatable.fromRAC(rac); final RowsAndColumns results = agger.aggregateAll( - new WindowFrame(WindowFrame.PeerType.ROWS, true, 0, true, 0, null), + WindowFrame.rows(null, null), Review Comment: `WindowFrame.unbounded()` is the same as `WindowFrame.rows(null,null)` ; during compilation we will do `unbounded` in those cases in `Windowing` changeds this call to `unbounded()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org