github-advanced-security[bot] commented on code in PR #16741: URL: https://github.com/apache/druid/pull/16741#discussion_r1678876831
########## sql/src/test/java/org/apache/druid/sql/calcite/CalciteWindowQueryTest.java: ########## @@ -184,47 +186,33 @@ log.info("Actual results:\n%s", sb.toString()); } } - } - - @MethodSource("parametersForWindowQueryTest") - @ParameterizedTest(name = "{0}") - @SuppressWarnings("unchecked") - public void windowQueryTest(String filename) throws Exception - { - TestCase testCase = new TestCase(filename); - - assumeTrue(testCase.getType() != TestType.failingTest); - if (testCase.getType() == TestType.operatorValidation) { - testBuilder() - .skipVectorize(true) - .sql(testCase.getSql()) - .queryContext(ImmutableMap.of( - PlannerContext.CTX_ENABLE_WINDOW_FNS, true, - QueryContexts.ENABLE_DEBUG, true - )) - .addCustomVerification(QueryVerification.ofResults(testCase)) - .run(); + public Map<? extends String, ? extends Object> getQueryContext() + { + return input.queryContext == null ? Collections.emptyMap() : input.queryContext; } } @MethodSource("parametersForWindowQueryTest") @ParameterizedTest(name = "{0}") @SuppressWarnings("unchecked") - public void windowQueryTestWithCustomContextMaxSubqueryBytes(String filename) throws Exception + public void windowQueryTest(String filename) throws Exception { TestCase testCase = new TestCase(filename); assumeTrue(testCase.getType() != TestType.failingTest); if (testCase.getType() == TestType.operatorValidation) { + Map<String, String> a = testCase.input.queryContext; Review Comment: ## Unread local variable Variable 'Map<String,String> a' is never read. [Show more details](https://github.com/apache/druid/security/code-scanning/7563) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org