Akshat-Jain opened a new pull request, #16754:
URL: https://github.com/apache/druid/pull/16754
### Description
Currently, if the query has any over() present without `partition by` clause
, we end up creating a single window stage and put all operators into that
window stage.
If we have everything in a single worker in a single stage, sorting wouldn’t
be possible as we’d have the entire data on a single worker.
This PR changes the logic to create separate window stages in such cases.
This PR also adds a bunch of test cases for queries having empty over(), as
well as a mix of empty and non-empty over() clauses - which run for both
sql-native and MSQ engine.
<hr>
##### Key changed/added classes in this PR
* `WindowOperatorQueryFrameProcessor`
* `WindowOperatorQueryFrameProcessorFactory`
* `WindowOperatorQueryKit`
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
