kgyrtkirk commented on code in PR #16754:
URL: https://github.com/apache/druid/pull/16754#discussion_r1683077744
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -187,14 +184,12 @@ public ReturnOrAwait<Object> runIncrementally(IntSet
readableInputs)
* We might think to reimplement them in the MSQ way so that we do not
have to materialize so much data
*/
- // Phase 1 of the execution
- // eagerly validate presence of empty OVER() clause
- if (isOverEmpty) {
Review Comment:
I did know that some coverage is missing in this area - but I wasn't
expecting that there will be no such covereage :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
