Akshat-Jain commented on code in PR #16754:
URL: https://github.com/apache/druid/pull/16754#discussion_r1682832452
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -187,14 +184,12 @@ public ReturnOrAwait<Object> runIncrementally(IntSet
readableInputs)
* We might think to reimplement them in the MSQ way so that we do not
have to materialize so much data
*/
- // Phase 1 of the execution
- // eagerly validate presence of empty OVER() clause
- if (isOverEmpty) {
Review Comment:
> why there are no tests which have broken?
Why would you expect any tests to break? These changes aren't expected to
change query results.
> I don't see any new tests which put expectations on the plans....
Right, I was hoping to finalise the query kit changes before I add tests for
asserting the generated MSQ spec. I was thinking of doing that in a separate
future PR, if that works?
> wouldn't all the added q/e tests pass without these changes?
Yes, but that's expected, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
