gianm commented on code in PR #16790:
URL: https://github.com/apache/druid/pull/16790#discussion_r1693367604
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerClient.java:
##########
@@ -77,20 +81,21 @@ void postResultsComplete(
/**
* Client side method to inform the controller that the error has occured in
the given worker.
+ *
+ * @param queryId query ID, if this error is associated with a specific
query
+ * @param errorWrapper error details
*/
void postWorkerError(
- String workerId,
+ @Nullable String queryId,
Review Comment:
Ah, I don't actually need to change this from `workerId` to `queryId` right
now. This was related to some other stuff I was tinkering with, about
supporting multiple queries running on the same worker id, but it isn't
important for this PR. I'll revert it.
Fwiw, the server side (`ControllerResource`) does not read this parameter,
so it currently doesn't matter what it is. That's probably why I didn't notice
the inconsistency when testing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
