LakshSingla commented on code in PR #16790: URL: https://github.com/apache/druid/pull/16790#discussion_r1694847573
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/output/StageOutputReader.java: ########## Review Comment: suggstion regarding naming of the class - `Output` is an overloaded term in MSQ. For example - outputChannel = readableChannel + writeableChannel. In the context of this class, the `StageOutputReader` only encapsulates the readability portion. Should we remove `output` from the name to avoid such a confusion? Something like `StageResultsReader` and `StageResultsHolder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
