LakshSingla commented on code in PR #16790: URL: https://github.com/apache/druid/pull/16790#discussion_r1694558918
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerMemoryParameters.java: ########## Review Comment: Since we use `maxConcurrentStages` in the memory parameters, I wonder if it should be the `maxConcurrentStages` that the user passes (present code), or if it should be the maximum concurrent stages that can happen given the query structure. For example, if each stage sorts in the query, the maximum concurrent stages that can happen = 1, however, if the user passes it as 10, we would be allocating less memory per stage even though it isn't required. Also, since it is not a user-facing change, I am debating if we should suggest reducing the `maxConcurrentStages` in the `NotEnoughMemoryFault`. Perhaps we should mention it if `maxConcurrentStages > 1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
