clintropolis opened a new pull request, #17386:
URL: https://github.com/apache/druid/pull/17386
### Description
changes:
* adds `CursorBuildSpec.getPhysicalColumns()` to allow specifying the set of
required physical columns from a segment. if null, all columns are assumed to
be required (e.g. full scan)
* `IncrementalIndexCursorFactory`/`IncrementalIndexCursorHolder` uses the
physical columns from the cursor build spec to know which set of dimensions to
'snapshot' the capabilities for, allowing expression selectors on realtime
queries to no longer be required to treat selectors from
`StringDimensionIndexer` as multi-valued unless they truly are multi-valued.
this fixes several bugs with expressions on realtime queries that change a
value from `StringDimensionIndexer` to some type other than string, which would
often result in a single element array from the column being handled as
multi-valued
* `StringDimensionIndexer.setSparseIndexed()` now adds the default value to
the dictionary when set
* `StringDimensionIndexer` column value selectors now always report that
they are dictionary encoded, and that name lookup is possible in advance on
their selectors (since set sparse adds the null value so the cardinality is
correct)
* fixed a mistake that expression selectors for realtime queries with no
null values could not use dictionary encoded selectors
#### Release note
_todo_
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
