clintropolis commented on code in PR #17386:
URL: https://github.com/apache/druid/pull/17386#discussion_r1873781637
##########
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentCursorFactory.java:
##########
@@ -149,6 +166,27 @@ public CursorHolder makeCursorHolder(CursorBuildSpec spec)
);
cursorBuildSpecBuilder.setVirtualColumns(preJoinVirtualColumns);
+ // add all physical columns columns if they were originally set
+ if (physicalColumns != null) {
Review Comment:
this was a good point and missing, and the way things were also resulted in
some join only columns getting pushed down to the base table cursor as physical
columns. I've updated things to add all of the columns from the clauses and
also filter out all of the columns with a join clause prefix to ensure that
only base table columns are specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
