gianm commented on code in PR #17386:
URL: https://github.com/apache/druid/pull/17386#discussion_r1869980626
##########
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentCursorFactory.java:
##########
@@ -149,6 +166,27 @@ public CursorHolder makeCursorHolder(CursorBuildSpec spec)
);
cursorBuildSpecBuilder.setVirtualColumns(preJoinVirtualColumns);
+ // add all physical columns columns if they were originally set
+ if (physicalColumns != null) {
Review Comment:
I meant, if we have a condition like `x = j0.y`, doesn't the base table
cursor need to have `x` added as a physical column? I would think yes but I
don't see the code that adds it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
