This is an automated email from the ASF dual-hosted git repository. sushuang pushed a commit to branch typescript in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 5283e42cce673af9157abc3187c2ba54361746da Author: 100pah <sushuang0...@gmail.com> AuthorDate: Sun Mar 1 07:04:09 2020 +0800 little typo. And move highDownXXX to ECElement. --- src/component/dataZoom/DataZoomModel.ts | 2 -- src/coord/single/Single.ts | 4 ++-- src/util/graphic.ts | 4 ++-- src/util/types.ts | 8 +++++--- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/component/dataZoom/DataZoomModel.ts b/src/component/dataZoom/DataZoomModel.ts index e508b21..d538d89 100644 --- a/src/component/dataZoom/DataZoomModel.ts +++ b/src/component/dataZoom/DataZoomModel.ts @@ -193,8 +193,6 @@ class DataZoomModel<Opts extends DataZoomOption = DataZoomOption> extends Compon init(option: Opts, parentModel: Model, ecModel: GlobalModel) { - this._rangePropMode = ['percent', 'percent']; - var inputRawOption = retrieveRawOption(option); /** diff --git a/src/coord/single/Single.ts b/src/coord/single/Single.ts index b6a34cd..7bb223d 100644 --- a/src/coord/single/Single.ts +++ b/src/coord/single/Single.ts @@ -251,8 +251,8 @@ class Single implements CoordinateSystem, CoordinateSystemMaster { function getCoordSys(finder: ParsedModelFinder): Single { const seriesModel = finder.seriesModel; - const polarModel = finder.singleAxisModel as SingleAxisModel; - return polarModel && polarModel.coordinateSystem + const singleModel = finder.singleAxisModel as SingleAxisModel; + return singleModel && singleModel.coordinateSystem || seriesModel && seriesModel.coordinateSystem as Single; } diff --git a/src/util/graphic.ts b/src/util/graphic.ts index 9a6fba1..9fa2b48 100644 --- a/src/util/graphic.ts +++ b/src/util/graphic.ts @@ -681,8 +681,8 @@ export function setAsHighDownDispatcher(el: Element, asDispatcher: boolean) { const extendedEl = el as ExtendedDisplayable; // Make `highDownSilentOnTouch` and `highDownOnUpdate` only work after // `setAsHighDownDispatcher` called. Avoid it is modified by user unexpectedly. - extendedEl.__highDownSilentOnTouch = extendedEl.highDownSilentOnTouch; - extendedEl.__highDownOnUpdate = extendedEl.highDownOnUpdate; + extendedEl.__highDownSilentOnTouch = (el as ECElement).highDownSilentOnTouch; + extendedEl.__highDownOnUpdate = (el as ECElement).highDownOnUpdate; // Simple optimize, since this method might be // called for each elements of a group in some cases. diff --git a/src/util/types.ts b/src/util/types.ts index 2d954b7..468fe91 100644 --- a/src/util/types.ts +++ b/src/util/types.ts @@ -101,9 +101,11 @@ export interface ECElement extends Element { seriesIndex?: number; dataType?: string; tooltip?: CommonTooltipOption<unknown> & { - content?: string - formatterParams?: unknown - } + content?: string; + formatterParams?: unknown; + }; + highDownSilentOnTouch?: boolean; + highDownOnUpdate?: (fromState: 'normal' | 'emphasis', toState: 'normal' | 'emphasis') => void; } export interface DataHost { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org